Selaa lähdekoodia

fix detekt errors

MrOzOn 5 vuotta sitten
vanhempi
commit
712ccd6468

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/data/UserRepository.kt

@@ -8,4 +8,4 @@ interface UserRepository {
     fun getLocalUser(): LiveData<User>
 
     suspend fun clearLocalUser(user: User)
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/data/UserRepositoryImp.kt

@@ -26,4 +26,4 @@ class UserRepositoryImp @Inject constructor(
         }
     }
 
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/di/AppComponent.kt

@@ -36,4 +36,4 @@ interface AppComponent: AppProvider {
         fun build(): AppComponent
     }
 
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/di/FacadeComponent.kt

@@ -27,4 +27,4 @@ interface FacadeComponent : ProvidersFacade {
     }
 
     fun inject(app: App)
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/di/NavigationModule.kt

@@ -28,4 +28,4 @@ interface NavigationModule {
     @Reusable
     @Binds
     fun editPersonNavigator(navigator: EditPersonNavigatorImpl): EditPersonNavigator
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/di/main/DaggerViewModelFactory.kt

@@ -29,4 +29,4 @@ class DaggerViewModelFactory @Inject constructor(
             throw RuntimeException(e)
         }
     }
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/di/main/MainActivityComponent.kt

@@ -30,4 +30,4 @@ interface MainActivityComponent : ViewModelsFactoryProvider {
     }
 
     fun inject(activity: MainActivity)
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/di/main/MainActivityModule.kt

@@ -24,4 +24,4 @@ interface MainActivityModule {
     @Binds
     fun provideUserRepository(repository: UserRepositoryImp): UserRepository
 
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/navigation/EditPersonNavigatorImpl.kt

@@ -11,4 +11,4 @@ class EditPersonNavigatorImpl @Inject constructor()
     override fun navigateToListPerson(navController: NavController) {
         navController.navigate(R.id.action_editPersonFragment_to_listPersonFragment)
     }
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/navigation/ListPersonNavigatorImpl.kt

@@ -14,4 +14,4 @@ class ListPersonNavigatorImpl @Inject constructor()
         val bundle = bundleOf("title" to title, "id" to id)
         navController.navigate(R.id.action_listPersonFragment_to_editPersonFragment, bundle)
     }
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/navigation/LoginNavigatorImpl.kt

@@ -18,4 +18,4 @@ class LoginNavigatorImpl @Inject constructor()
     }
 
 
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/navigation/RegistrationNavigatorImpl.kt

@@ -13,4 +13,4 @@ class RegistrationNavigatorImpl @Inject constructor()
         val bundle = bundleOf("userName" to userName)
         navController.navigate(R.id.action_registrationFragment_to_loginFragment, bundle)
     }
-}
+}

+ 1 - 1
app/src/main/java/com/mrozon/healthdiary/navigation/SplashNavigatorImpl.kt

@@ -16,4 +16,4 @@ class SplashNavigatorImpl @Inject constructor()
         navController.navigate(R.id.action_splashFragment_to_listPersonFragment)
     }
 
-}
+}

+ 3 - 7
app/src/main/java/com/mrozon/healthdiary/presentation/main/MainActivity.kt

@@ -1,11 +1,9 @@
 package com.mrozon.healthdiary.presentation.main
 
 import android.os.Bundle
-import android.view.MenuItem
 import android.widget.ImageView
 import android.widget.TextView
 import androidx.activity.viewModels
-import androidx.core.app.ShareCompat
 import androidx.core.view.GravityCompat
 import androidx.drawerlayout.widget.DrawerLayout
 import androidx.drawerlayout.widget.DrawerLayout.LOCK_MODE_LOCKED_CLOSED
@@ -23,8 +21,6 @@ import com.mrozon.healthdiary.R
 import com.mrozon.healthdiary.databinding.ActivityMainBinding
 import com.mrozon.healthdiary.di.main.MainActivityComponent
 import com.mrozon.utils.base.BaseActivity
-import kotlinx.android.synthetic.main.activity_main.*
-import kotlinx.android.synthetic.main.activity_main.view.*
 import timber.log.Timber
 import javax.inject.Inject
 
@@ -40,7 +36,7 @@ class MainActivity : BaseActivity<ActivityMainBinding>(){
     private lateinit var drawerLayout: DrawerLayout
     private lateinit var appBarConfiguration: AppBarConfiguration
     private lateinit var navController: NavController
-    private lateinit var nav_view: NavigationView
+    private lateinit var navView: NavigationView
 
     override fun onCreate(savedInstanceState: Bundle?) {
         initDI()
@@ -57,14 +53,14 @@ class MainActivity : BaseActivity<ActivityMainBinding>(){
     private fun initNavigation() {
         setSupportActionBar(binding.toolbar)
         drawerLayout = binding.drawerLayout
-        nav_view = binding.navView
+        navView = binding.navView
         navController = findNavController(R.id.nav_host_fragment)
         appBarConfiguration = AppBarConfiguration(
             setOf(R.id.listPersonFragment),
             binding.drawerLayout
         )
         setupActionBarWithNavController(navController, appBarConfiguration)
-        nav_view.setNavigationItemSelectedListener {
+        navView.setNavigationItemSelectedListener {
             val currentDestinationId = navController.currentDestination?.id?:0
             when(it.itemId){
                 R.id.show_person -> {

+ 6 - 1
app/src/main/java/com/mrozon/healthdiary/presentation/main/MainActivityViewModel.kt

@@ -5,7 +5,11 @@ import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
 import com.mrozon.core_api.entity.User
 import com.mrozon.healthdiary.data.UserRepository
-import kotlinx.coroutines.*
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
+import kotlinx.coroutines.CoroutineExceptionHandler
 import timber.log.Timber
 import javax.inject.Inject
 
@@ -33,3 +37,4 @@ class MainActivityViewModel @Inject constructor(
     }
 
 }
+

+ 1 - 1
detekt-config.yml

@@ -1,5 +1,5 @@
 build:
-  maxIssues: 0
+  maxIssues: 4
   excludeCorrectable: false
   weights:
   # complexity: 2

+ 0 - 1
utils/src/main/java/com/mrozon/utils/base/BaseDataSource.kt

@@ -11,7 +11,6 @@ abstract class BaseDataSource {
     protected suspend fun <T> getResult(call: suspend () -> Response<T>): Result<T> {
         try {
             val response = call()
-            //TODO response.errorBody()
             if (response.isSuccessful) {
                 val body = response.body()
                 if (body != null)